Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto empty response #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

darkv
Copy link

@darkv darkv commented Dec 2, 2018

The current behavior when you do not return a value from your controller method is that an empty 200 response without CORS header is returned to the client.

This patch adds handling of empty responses by adding CORS header if configured and sets the HTTP status code to the appropriate 204 – No Content.

Copy link
Collaborator

@tyzoid tyzoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants